INDY-2316 Allow multiple active TAAs: Debug #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-2297-get-taa-digest
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Toktar
requested review from
lampkin-diet,
ashcherbakov and
skhoroshavin
as code owners
|
This pull request introduces 1 alert when merging a143655 into f2d582b - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging b3883b9 into f2d582b - view on LGTM.com new alerts:
|
Toktar
commented
Dec 23, 2019
| @@ -46,7 +46,7 @@ def check_audit_txn(txn, | |||
| "txn": { | |||
| "data": { | |||
| "ledgerRoot": expectedLedgerRoots, | |||
| "ver": CURRENT_TXN_VERSIONS[AUDIT], | |||
| "ver": CURRENT_TXN_PAYLOAD_VERSIONS[AUDIT], | |||
ashcherbakov
previously approved these changes
Dec 23, 2019
|
This pull request introduces 2 alerts when merging 39c6121 into f2d582b - view on LGTM.com new alerts:
|
| @@ -83,7 +83,7 @@ def _create_audit_txn_data(self, three_pc_batch, last_audit_txn): | |||
| # 1. general format and (view_no, pp_seq_no) | |||
| view_no = three_pc_batch.original_view_no if three_pc_batch.original_view_no is not None else three_pc_batch.view_no | |||
| txn = { | |||
| TXN_VERSION: CURRENT_TXN_VERSIONS[AUDIT], | |||
| TXN_VERSION: CURRENT_TXN_VERSION, | |||
There was a problem hiding this comment.
CURRENT_TXN_PAYLOAD_VERSIONS needs to be used here
|
This pull request introduces 2 alerts when merging 89dc75f into f2d582b - view on LGTM.com new alerts:
|
ashcherbakov
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: