INDY-2313: Require ratification_ts to create TAA #1437
Conversation
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
requested review from
lampkin-diet,
ashcherbakov and
Toktar
as code owners
skhoroshavin
changed the title
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
changed the title
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request introduces 2 alerts when merging e98d6d0 into f2d582b - view on LGTM.com new alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
| "Cannot create transaction author agreement without a '{}' field." | ||
| .format(TXN_AUTHOR_AGREEMENT_RATIFICATION_TS)) | ||
|
|
||
| if ratification_ts > req_pp_time: |
There was a problem hiding this comment.
Do we consider some Delta (for a possible clock skew) here?
There was a problem hiding this comment.
Good question. We might need it, but it wasn't in requirements. Also, I think this shouldn't be a problem since production use case most probably will look like:
- create TAA txn with ratification time current or earlier
- pass TAA txn to trustees so they sign it (this process most probably will take at least several minutes)
- submit signed TAA txn - with ratification date already well in the past
Also, when author of TAA txn is trustee and he wants to send txn immediately he can put ratification date into the past himself (which is also done by integration tests).
|
This pull request introduces 1 alert when merging 1a89ca4 into f2d582b - view on LGTM.com new alerts:
|
skhoroshavin
dismissed stale reviews from Toktar and ashcherbakov
via
0aaed82
|
This pull request introduces 1 alert when merging 0aaed82 into 021a81e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging f716aae into 4350709 - view on LGTM.com new alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging 72acf37 into f7492a0 - view on LGTM.com new alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com