[INDY-2324] Add random initial view no for sim pool #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2020 16:52
…m pool Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
lampkin-diet
requested review from
ashcherbakov,
skhoroshavin and
Toktar
as code owners
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
…m tests Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
…y-2324 Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
lampkin-diet
changed the title
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
…y-2324 Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
| @@ -104,6 +113,12 @@ def __init__(self, name: str, validators: List[str], primary_name: str, | |||
| # ToDo: ugly way to understand node_reg changing | |||
| self._previous_node_reg = self._write_manager.node_reg_handler.committed_node_reg | |||
|
|
|||
| def setup_view_no(self, view_no=None): | |||
| self._data.view_no = view_no | |||
| self._data.primaries = self._primaries_selector.select_primaries(view_no) | |||
There was a problem hiding this comment.
We don't have primaries field in ConsensusSharedData anymore
| def test_view_change_while_ordering_with_real_msgs_default_seed(seed): | ||
| do_test(seed) | ||
| def test_view_change_while_ordering_with_real_msgs_random_seed(random): | ||
| do_test(random) | ||
|
|
||
|
|
There was a problem hiding this comment.
Why did we remove fixed seed here? I think we need to keep for regression test purposes.
There was a problem hiding this comment.
I removed only simple seed from 0 to 100.
There was a problem hiding this comment.
I returned back fixed seed.
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging c4b8408 into ea38ac1 - view on LGTM.com new alerts:
|
added 2 commits
January 22, 2020 17:36
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging a08287d into ea38ac1 - view on LGTM.com new alerts:
|
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging fbd6de1 into ea38ac1 - view on LGTM.com new alerts:
|
added 2 commits
January 23, 2020 13:03
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging e50ae8e into bdc8d05 - view on LGTM.com new alerts:
|
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging f59b184 into bdc8d05 - view on LGTM.com new alerts:
|
ashcherbakov
approved these changes
Jan 23, 2020
ashcherbakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.