[FIX] fix client-related behaviour #1479
Conversation
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
lampkin-diet
requested review from
ashcherbakov,
skhoroshavin and
Toktar
as code owners
|
This pull request introduces 1 alert when merging 7dea3a9 into 95a13b4 - view on LGTM.com new alerts:
|
plenum/server/node.py
Outdated
| def send_ledger_status_to_client(self, lid, txn_s_n, v, p, merkle, protocol, client): | ||
| ls = LedgerStatus(lid, txn_s_n, v, p, merkle, protocol) | ||
| self.transmitToClient(ls, client) | ||
| def send_ledger_status_to_client(self, msg, client): |
There was a problem hiding this comment.
I may be wrong, but I think that re-creation of a LedgerStatus was done explicitly in order to pass CURRENT_PROTOCOL_VERSION there. I think it wad important for some compatibility cases. Not sure if this is still a valid compatibility case, but I think it's worth double-checking.
There was a problem hiding this comment.
The problem exactly in recreation process. If there was an error with LedgerStatus schema (as in test i send a message with merkleRoot parameter as null not str) then creation LedgerStatus object back will cause the same error too. I think, that in this case we need to reply to client the same message with error describing.
| from stp_core.loop.eventually import eventually | ||
|
|
||
|
|
||
| @pytest.fixture(params=[zmq.REQ]) |
There was a problem hiding this comment.
Can we check other socket types? SUB, PUB, ROUTER, etc.
There was a problem hiding this comment.
For other socket types we will have another behaviour. All of this cases will cause to ZMQErrors.
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging a772865 into 95a13b4 - view on LGTM.com new alerts:
|
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
…nto fix_zmq_fails
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
…ocol version Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
|
This pull request introduces 1 alert and fixes 1 when merging 7fb710a into 95a13b4 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Andrew Nikitin andrew.nikitin@dsr-corporation.com