Some changes needed for Ubuntu 20.04 support #1480
Conversation
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
requested review from
lampkin-diet,
ashcherbakov and
Toktar
as code owners
| @@ -104,7 +104,7 @@ def run(self): | |||
| 'ioflo==1.5.4', | |||
| 'semver==2.7.9', | |||
| 'base58==1.0.0', | |||
| 'orderedset==2.0', | |||
| 'orderedset==2.0.3', | |||
There was a problem hiding this comment.
I believe it needs to be specified in build-scripts/ubuntu-1604/build-3rd-parties.sh as well (and in indy-node's repo too).
There was a problem hiding this comment.
Thanks for pointing out this
| @@ -117,7 +117,7 @@ def run(self): | |||
| 'indy-crypto==0.4.5', | |||
| 'python-rocksdb==0.6.9', | |||
| 'python-dateutil==2.6.1', | |||
| 'pympler==0.5', | |||
| 'pympler==0.8', | |||
There was a problem hiding this comment.
I believe it needs to be specified in build-scripts/ubuntu-1604/build-3rd-parties.sh as well (and in indy-node's repo too).
| @@ -346,7 +346,7 @@ def z85_to_friendly(z): | |||
|
|
|||
| def runWithLoop(loop, callback, *args, **kwargs): | |||
| if loop.is_running(): | |||
| loop.call_soon(asyncio.async, callback(*args, **kwargs)) | |||
| loop.call_soon(asyncio.ensure_future, callback(*args, **kwargs)) | |||
There was a problem hiding this comment.
Is it a breaking change?
Please have a look at the following PR: https://github.com/hyperledger/indy-plenum/pull/974/files
There was a problem hiding this comment.
It shouldn't be - according to this part of Python 3.5 documentation async is just a wrapper for ensure_future and was already deprecated by that time.
|
This pull request introduces 5 alerts and fixes 1 when merging 6252ac5 into b4a8aa0 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request introduces 2 alerts and fixes 1 when merging dfbb54a into b4a8aa0 - view on LGTM.com new alerts:
fixed alerts:
|
|
(ci) test this please |
|
Could we please merge this? :) |
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com