Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UP-34]: add LEDGERS_FREEZE and GET_FROZEN_LEDGERS transactions #1502

Merged
merged 12 commits into from
Feb 10, 2021
Merged

[UP-34]: add LEDGERS_FREEZE and GET_FROZEN_LEDGERS transactions #1502

merged 12 commits into from
Feb 10, 2021

Conversation

Toktar
Copy link
Contributor

@Toktar Toktar commented Jan 11, 2021

Signed-off-by: toktar renata.toktar@dsr-corporation.com

@Toktar
UP-34: add an integration tests for a case with removing plugins
8686ac7 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@Toktar
UP-34: add get_auction txn to demo_plugin
9a082cc 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@Toktar
UP-34: move freeze ledgers transactions from indy-node to indy-plenum
10926f5 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 3 alerts when merging 10926f5 into a079571 - view on LGTM.com

new alerts:

  • 2 for Module-level cyclic import
  • 1 for Unreachable code

@Toktar
UP-34: change dynamic_validation in WriteRequestHandler
aacde22 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 3 alerts when merging aacde22 into a079571 - view on LGTM.com

new alerts:

  • 2 for Module-level cyclic import
  • 1 for Unreachable code

@Toktar
UP-34: add frozen ledgers stubs to catchup and audit handler
d50f651 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2021

This pull request introduces 1 alert when merging d50f651 into a079571 - view on LGTM.com

new alerts:

  • 1 for Unused import

@Toktar Toktar changed the title [WIP][ci skip][UP-34]: add an integration tests for a case with removing plugins [WIP][UP-34]: add an integration tests for a case with removing plugins Jan 29, 2021
@Toktar
Copy link
Contributor Author

Toktar commented Jan 29, 2021

(ci) test this please

@Toktar
UP-34: fix flake8 warnings
c4db31c 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@Toktar
UP-34: fix incorrect imports
a31b013 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 1, 2021

This pull request introduces 1 alert when merging a31b013 into a079571 - view on LGTM.com

new alerts:

  • 1 for Unused import

@esplinr esplinr mentioned this pull request Feb 2, 2021
Merged
@Toktar
UP-34: add ledgers freeze stub in catchup and audit mechanism
3241f50 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@Toktar
UP-34: add unit tests for LedgersFreezeHandler
ac59e0c 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@Toktar Toktar changed the title [WIP][UP-34]: add an integration tests for a case with removing plugins [UP-34]: add LEDGERS_FREEZE and GET_FROZEN_LEDGERS transactions Feb 5, 2021
@Toktar
UP-34: update tests
05e6990 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@Toktar
UP-34: update the integration test for ledgers freezing
77f4669 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
@Toktar
Copy link
Contributor Author

Toktar commented Feb 5, 2021

[CI] Test this please

askolesov
askolesov previously approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@askolesov askolesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just a couple of minor suggestions from my side.

plenum/server/batch_handlers/audit_batch_handler.py Outdated Show resolved Hide resolved
plenum/server/batch_handlers/audit_batch_handler.py Show resolved Hide resolved
plenum/server/request_handlers/handler_interfaces/write_request_handler.py Outdated Show resolved Hide resolved
plenum/test/freeze_ledgers/helper.py Outdated Show resolved Hide resolved
plenum/test/plugin/demo_plugin/request_handlers/auction_start_handler.py Outdated Show resolved Hide resolved
@Toktar
UP-34: fix ledgers_freeze_handler and small refactoring
0448f51 
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
WadeBarnes
WadeBarnes reviewed Feb 9, 2021
View reviewed changes
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the level of authorization required to freeze a ledger ... Along with the requirement of being a Trustee, would it be an idea to also require one or more signatures from additional Trustees? Freezing a ledger is a big decision.

@Toktar
Copy link
Contributor Author

Toktar commented Feb 9, 2021

@WadeBarnes Sure, we add a requirement of 3 trustees signatures here hyperledger/indy-node#1641
And Indy Plenum can't be used without Indy Node.
What do you think, in this case, it looks ok?

askolesov
askolesov approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@askolesov askolesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@skhoroshavin skhoroshavin merged commit 5ca2593 into hyperledger:master Feb 10, 2021
@WadeBarnes
Copy link
Member

@WadeBarnes Sure, we add a requirement of 3 trustees signatures here hyperledger/indy-node#1641
And Indy Plenum can't be used without Indy Node.
What do you think, in this case, it looks ok?

Agreed looks good. Sorry for being late to the party.

Toktar pushed a commit to Toktar/indy-plenum that referenced this pull request Mar 1, 2021
@skhoroshavin
Merge pull request hyperledger#1502 from Toktar/up-34-ledger-removing
37b109f 
[UP-34]: add LEDGERS_FREEZE and GET_FROZEN_LEDGERS transactions

Signed-off-by: Sergey Khoroshavin <skhoroshavin@users.noreply.github.com>
Sign-off-executed-by: toktar <renata.toktar@evernym.com>
Approved-at: h-master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WadeBarnes WadeBarnes WadeBarnes left review comments

@skhoroshavin skhoroshavin skhoroshavin approved these changes

@askolesov askolesov askolesov approved these changes

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

@ashcherbakov ashcherbakov Awaiting requested review from ashcherbakov

Assignees

@skhoroshavin skhoroshavin

@askolesov askolesov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Toktar @WadeBarnes @skhoroshavin @askolesov