Upgrade Ubuntu 20.04

[adenishchenko]

No description provided.

[WadeBarnes]

@ryMarsh44, @Toktar, @adenishchenko, What is the relationship between this PR and #1509? Can #1509 be closed in favor of this PR?

[WadeBarnes]

@ryMarsh44, @Toktar, @adenishchenko, @udosson, If I understand correctly, based on the Indy Contributors call today, this PR can be taken out of WIP status. Is that correct?

[Toktar]

@WadeBarnes, #1509 can be closed. This PR contains the previous one.
I don't think that WIP status should be removed because I recommend merge it after adding GitHub Actions pipelines for Ubuntu 20.04.

[askolesov]

But all tests pass locally

[WadeBarnes]

@Toktar, @askolesov, This PR contains GHA workflows @udosson developed for the Ubuntu 20.04 upgrade. Does it not?

[Toktar]

@WadeBarnes Yes, it is. But GHAs for Ubuntu20.04 doesn't work partly, and we are working on them in my fork https://github.com/Toktar/indy-plenum/actions/runs/701558875
We can start to launch the PR there I think.

[WadeBarnes]

@Toktar, Great!. I'm getting the same results. Since you're already working on it I'll leave it to you.

There have been some updates to the workflows that need to be integrated in order to fix some of the issues you are seeing and also integrate the CD portion of the flows that @ianco and @udosson added to the version in the main branch; https://github.com/hyperledger/indy-plenum/blob/master/.github/workflows/build.yaml

Namely these changes need to be integrated while the detection of Ubuntu 16.04 vs 20.04 is retained from the version on this branch:

• Github actions CD steps for plenum #1519
• Add settings file. #1521
• Publish tests report steps are now allowed to fail #1523
• Split CD release into two parts, added caching, and extended Docker file #1526

[WadeBarnes]

@Toktar, also, if you add ubuntu-20.04-upgrade to the list of branches, the workflows will be triggered when you commit to this PR.

[WadeBarnes]

Testing the latest updates over here; https://github.com/WadeBarnes/indy-plenum/actions/runs/726225931

[askolesov]

Yeah, it was also running in Anton's repo but failing here for some reason

[adenishchenko]

@WadeBarnes Yes, I fixed it and tested in my repo https://github.com/adenishchenko/indy-plenum/actions/runs/718983014. All tests pass but in the PR we still have an issue with a secret, I think.
Error message:
perform an interactive login from a non TTY device
I guess, I don't have permissions for fix it.

[WadeBarnes]

All tests are passing on Ubuntu 20.04. There is still some work to be done on the GHA workflows, but that can be done on follow-up PRs. I'd like to get this PR merged into the ubuntu-20.04 branch so the GHA images can get built and cached, and we can call the majority of the upgrade/migration work complete.

Any objections, @adenishchenko, @Toktar, @askolesov, @udosson?

[askolesov]

No objections, but how are we going to do the first release on Ubuntu 16 if we merge it now?

[WadeBarnes]

@WadeBarnes Yes, I fixed it and tested in my repo https://github.com/adenishchenko/indy-plenum/actions/runs/718983014. All tests pass but in the PR we still have an issue with a secret, I think.
Error message:
perform an interactive login from a non TTY device
I guess, I don't have permissions for fix it.

This is expected. PRs don't have access to the repository secrets.

[WadeBarnes]

No objections, but how are we going to do the first release on Ubuntu 16 if we merge it now?

This is going into the ubuntu-20.04-upgrade branch, the 16.04 release will be done off another branch.

[askolesov]

Right, thanks. Too many branches...