-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python packaging and uploading to PyPI #1547
Python packaging and uploading to PyPI #1547
Conversation
Can one of the admins verify this patch? |
.github/workflows/build.yaml
Outdated
python3 -m pip install pytest-runner wheel pip==9.0.3 | ||
|
||
- name: Set Build Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be removed here and upstreamVer could be used from the job build_release. However, setting the build version here as well allows for parallel processing
@udosson, |
@WadeBarnes thanks for your comment. However, if I try to install
https://github.com/hyperledger/indy-plenum/blob/master/build-scripts/ubuntu-1604/prepare-package.sh#L21-L24 sets the python packages according to the versions of the packages in Launchpad. E.g. I think the reason for this pinning is because
For the PyPI package, we need to install the dependencies as such as ujson==1.33 and we cannot change the version tag to the version of the Canonical archive. |
I just came to the same conclusion. I dug a bit deeper and I see that it is only needed for the deb package build, and the version of I think we should merge the two scripts together so there isn't the confusion over having two almost identical scripts. I can take a pass at that. |
@udosson, My other recommendation would be to separate the PyPi package build from the publishing to keep it consistent with how the That way we're always excising the package builds, and then only publishing them when appropriate. |
@WadeBarnes thanks for your suggestion. |
.github/workflows/build.yaml
Outdated
|
||
- name: Install required packages via pip | ||
run: | | ||
python3 -m pip install pytest-runner wheel pip==9.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of #1548 the pip version does not need to be overridden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @andrewwhitehead. I update the PR and removed the pinned pip version.
@udosson any chance for a squash-like commit to tidy up and fix the DCO issue? |
Signed-off-by: udosson <r.klemens@yahoo.de>
a51da0c
to
3cbbc6d
Compare
@ryjones, done! |
(ci) test this please |
This PR contains the building and publishing of the Python package of Plenum to PyPI.
A successful test tun of the PR can be found in this GHA run. For testing purposes, the indy-plenum package was published to TestPyPi. The indy-plenum package of the test can be installed via
python3 -m pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple indy-plenum==1.13.0.dev133
.@ryjones could you create a secret called
PYPI_API_TOKEN
according to PyPI docs, please? This is needed to publish the package to PyPI. Thanks!Signed-off-by: udosson r.klemens@yahoo.de