Merge pull request #85 from Warchant/hotfix/fix-make-warnings

Fixed warnings during make

.gitignore

@@ -15,3 +15,4 @@ build/*
 .vscode/*
 .idea/*
 *xcworkspace*
+.vscode/*

core/consensus/consensus_event.hpp

@@ -89,7 +89,7 @@ class ConsensusEvent: public T, public Event {
         return T::getHash();
     }
 
-    int getNumValidSignatures() {
+    unsigned int getNumValidSignatures() {
         return std::count_if(
                 _eventSignatures.begin(), _eventSignatures.end(),
             [hash = getHash()](eventSignature sig){

core/consensus/event.hpp

@@ -29,7 +29,7 @@ class Event {
 public:
   int order = 0;
   virtual void addSignature(const std::string& publicKey, const std::string& signature) = 0;
-  virtual int getNumValidSignatures() = 0;
+  virtual unsigned int getNumValidSignatures() = 0;
   virtual bool eventSignatureIsEmpty() = 0;
   virtual std::vector<std::tuple<std::string,std::string>> eventSignatures() = 0;
   virtual std::string getHash() = 0;

core/model/transaction.cpp

@@ -13,8 +13,8 @@ namespace transaction{
         Transfer(
             obj.dictSub["command"]
         ),
-        senderPubkey(obj.dictSub["senderPublicKey"].str),
-        hash(obj.dictSub["hash"].str)
+        hash(obj.dictSub["hash"].str),
+        senderPubkey(obj.dictSub["senderPublicKey"].str)
     {
 
         std::vector<Object> txSigs = obj.dictSub["txSignatures"].listSub;
@@ -62,13 +62,13 @@ namespace transaction{
         const std::string& name,
         const int& value
     ):
-        senderPubkey(senderPubkey),
         Transfer(
             senderPubkey,
             receiverPubkey,
             name,
             value
-        )
+        ),
+        senderPubkey(senderPubkey)
     {}
 
     template <>
@@ -79,13 +79,13 @@ namespace transaction{
         const unsigned long long& value,
         const unsigned int& precision
     ):
-        senderPubkey(senderPubkey),
         Add(
             domain,
             name,
             value,
             precision
-        )    
+        ),
+        senderPubkey(senderPubkey)
     {}
 
     template <>
@@ -94,11 +94,11 @@ namespace transaction{
         const std::string& ownerPublicKey,
         const std::string& name
     ):
-        senderPubkey(senderPubkey),
         Add(
             ownerPublicKey,
             name
-        )    
+        ),
+        senderPubkey(senderPubkey)
     {}
 
 }

core/repository/consensus/merkle_transaction_repository.hpp

@@ -83,15 +83,15 @@ struct MerkleNode {
 
 //TODO: change bool to throw an exception instead
 bool commit(const std::unique_ptr<event::Event>& event){
-
+    return false; // TODO: fill this function
 };
 
 bool leafExists(const std::string& hash){
-
+    return false; // TODO: fill this function
 }
 
 std::string getLeaf(const std::string& hash){
-
+    return ""; // TODO: fill this function
 }
 
 template <typename T>