Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction status sometimes is not sent by peer #1492

Closed
rkharisov opened this issue Sep 30, 2021 · 2 comments
Closed

Transaction status sometimes is not sent by peer #1492

rkharisov opened this issue Sep 30, 2021 · 2 comments
Assignees
@e-ivkov
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@rkharisov
Copy link

rkharisov commented Sep 30, 2021 •
edited

Precondition: client subscribes to transaction status and as soon as peer responds with SubscriptionAccepted event the client sends transaction itself.

Expected: Event with transaction status (Committed, Rejected, Validating) is received from peer.

Actual: No event about transaction is sent by peer

Note 1. Transaction eventually committed, just no status about it received

Note 2. Transactions are not MST

Note 3. Usually subscription is accepted by one peer, but transaction is sent to another

Note 4. This problem is raised from time to time, not with every transaction
@rkharisov rkharisov added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 30, 2021
i1i1 added a commit to i1i1/iroha that referenced this issue Sep 30, 2021
@i1i1
Fix transaction status events hyperledger#1492
58a37b0 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1 added a commit to i1i1/iroha that referenced this issue Sep 30, 2021
@i1i1
Fix transaction status events hyperledger#1492
85cf2b8 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1 added a commit to i1i1/iroha that referenced this issue Sep 30, 2021
@i1i1
Fix transaction status events hyperledger#1492
df63aaf 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1 added a commit to i1i1/iroha that referenced this issue Sep 30, 2021
@i1i1
Fix transaction status events hyperledger#1492
ba58795 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1 added a commit to i1i1/iroha that referenced this issue Sep 30, 2021
@i1i1
Fix transaction status events hyperledger#1492
0d7c848 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1 added a commit to i1i1/iroha that referenced this issue Oct 1, 2021
@i1i1
Fix transaction status events hyperledger#1492
698f0ad 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1 added a commit to i1i1/iroha that referenced this issue Oct 1, 2021
@i1i1
Fix transaction status events hyperledger#1492
291a8c6 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1 added a commit to i1i1/iroha that referenced this issue Oct 4, 2021
@i1i1
Fix transaction status events hyperledger#1492
5b7f301 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1 added a commit to i1i1/iroha that referenced this issue Oct 5, 2021
@i1i1
Fix transaction status events hyperledger#1492
abc57c8 
Signed-off-by: i1i1 <vanyarybin1@live.ru>
@e-ivkov e-ivkov added the Bug Something isn't working label Oct 25, 2021
@e-ivkov e-ivkov mentioned this issue Oct 25, 2021
Closed
@e-ivkov e-ivkov self-assigned this Nov 9, 2021
@e-ivkov e-ivkov mentioned this issue Nov 23, 2021
Merged
@e-ivkov e-ivkov changed the title Transaction status sometimes does not send by peer Transaction status sometimes is not sent by peer Nov 23, 2021
@e-ivkov e-ivkov closed this as completed Nov 25, 2021
@e-ivkov
Copy link
Contributor

e-ivkov commented Nov 25, 2021

Issue closed as we could not reproduce the bug. Though we added better description and a more extensive test.

@appetrosyan
Copy link
Contributor

The issue seems to persist

https://github.com/hyperledger/iroha/runs/4369233906?check_suite_focus=true

@appetrosyan appetrosyan reopened this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-ivkov e-ivkov

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@appetrosyan @e-ivkov @rkharisov