Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listen_for_events() in Client #2005

Closed
Arjentix opened this issue Mar 24, 2022 · 0 comments
Closed

Fix listen_for_events() in Client #2005

Arjentix opened this issue Mar 24, 2022 · 0 comments
Assignees
Labels
Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@Arjentix
Copy link
Contributor

When running some integration tests that use event subscription (for example time_trigger_execution_count_error_should_be_less_than_10_percent) an error message apears in log:

ERROR iroha::torii::routing: Failed to subscribe someone error=Event consuming error: WebSocket error: WebSocket protocol error: Connection reset without closing handshake

So Client uses API a bit wrong and doesn't close subscription connection properly. To make closing handshake a WebSocket::close() method should be called on stream field of EventIterator.

Ideally this fix should provide the same good-looking API as before. User shouldn't close connection manualy

@Arjentix Arjentix added Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Mar 24, 2022
@Arjentix Arjentix self-assigned this Apr 12, 2022
mversic pushed a commit to mversic/iroha that referenced this issue May 2, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 4, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
… WebSocket stream (hyperledger#2095)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
… WebSocket stream (hyperledger#2095)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
… WebSocket stream (hyperledger#2095)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
mversic pushed a commit to mversic/iroha that referenced this issue May 13, 2022
mversic pushed a commit to mversic/iroha that referenced this issue May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

1 participant