[fix] #2005: Fix Client::listen_for_events() not closing WebSocket stream
#2095
+31
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
mversic
approved these changes
Apr 12, 2022
mversic
reviewed
Apr 12, 2022
appetrosyan
approved these changes
Apr 13, 2022
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 2, 2022
… WebSocket stream (hyperledger#2095)
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 4, 2022
… WebSocket stream (hyperledger#2095)
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
… WebSocket stream (hyperledger#2095)
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
… WebSocket stream (hyperledger#2095)
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
… WebSocket stream (hyperledger#2095) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
… WebSocket stream (hyperledger#2095) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
… WebSocket stream (hyperledger#2095) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
… WebSocket stream (hyperledger#2095)
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
… WebSocket stream (hyperledger#2095)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Client::listen_for_events()not closing WebSocket streamtoriidoing only part of WebSocket handshakeIssue
listen_for_events()inClient#2005Benefits
Now event streaming satisfies WebSocket protocol
Possible Drawbacks
None