Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a iroha procedural macro for impl FromStr for AssetValueType and other C like enums #2056

Closed
SamHSmith opened this issue Apr 4, 2022 · 0 comments
Closed

Create a iroha procedural macro for impl FromStr for AssetValueType and other C like enums #2056

SamHSmith opened this issue Apr 4, 2022 · 0 comments
Assignees
@ilchu
Labels
Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@SamHSmith
Copy link
Contributor

The following macro invokation

easy_from_str_impl! {AssetValueType, Quantity, BigQuantity, Fixed, Store}

does not automatically generate code for all variants. This should be replaced with a custom derive macro for FromStr.
@SamHSmith SamHSmith mentioned this issue Apr 4, 2022
Merged
@SamHSmith SamHSmith added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 5, 2022
@appetrosyan appetrosyan added the good first issue Good for newcomers label Apr 19, 2022
@ilchu ilchu self-assigned this May 12, 2022
ilchu added a commit to ilchu/iroha that referenced this issue May 15, 2022
@ilchu
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
5e57f97 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
@ilchu ilchu mentioned this issue May 15, 2022
Merged
ilchu added a commit to ilchu/iroha that referenced this issue May 16, 2022
@ilchu
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
cbc5fee 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue May 16, 2022
@ilchu
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
7b7ef44 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue May 16, 2022
@ilchu
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
e65dc29 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue May 16, 2022
@ilchu
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
a91ff6e 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue May 16, 2022
@ilchu
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
87f4395 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue May 16, 2022
@ilchu
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
cc6242a 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit that referenced this issue May 17, 2022
@ilchu
[feature] #2056: Add a derive proc macro crate for AssetValueType enum
1144ccf 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
@ilchu ilchu closed this as completed May 17, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 17, 2022
@ilchu @appetrosyan
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
00b0722 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
appetrosyan pushed a commit that referenced this issue May 18, 2022
@ilchu @appetrosyan
[feature] #2056: Add a derive proc macro crate for AssetValueType enum
0d43581 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
pesterev pushed a commit to pesterev/iroha that referenced this issue May 25, 2022
@ilchu @pesterev
[feature] hyperledger#2056: Add a derive proc macro crate for AssetVa…
ba66fbb 
…lueType enum

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilchu ilchu

Labels
Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SamHSmith @appetrosyan @ilchu