Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum for PublicKey/PrivateKey digest function #2123

Closed
mversic opened this issue Apr 19, 2022 · 6 comments
Closed

Use enum for PublicKey/PrivateKey digest function #2123

mversic opened this issue Apr 19, 2022 · 6 comments
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Apr 19, 2022 •
edited

Both PublicKey and PrivateKey store their respective digest functions as a string. They should store it as an Algorithm enum provided in the iroha_crypto crate.
@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST good first issue Good for newcomers labels Apr 19, 2022
@mversic mversic changed the title Use enum for PublicKey/PrivateKey digesti function Use enum for PublicKey/PrivateKey digest function Apr 20, 2022
@0xt3j4s
Copy link

0xt3j4s commented May 7, 2022

Can I please work on this issue?

@Erigara Erigara mentioned this issue Dec 9, 2022
Closed
@Retssaze
Copy link
Contributor

Thanks, very good one. It looks like I got what it is needed to do

@appetrosyan
Copy link
Contributor

Good. Let me know if you want to set up a meeting and discuss the work in more detail.

@Retssaze
Copy link
Contributor

Retssaze commented Dec 22, 2022 •
edited

Thank you very much for your kidness. It would be nice to have a little introduction

@Retssaze
Copy link
Contributor

Retssaze commented Dec 27, 2022 via email •
edited

@Retssaze
Copy link
Contributor

It looks like I did something

Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 8, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
df20726 
hyperledger#3055

Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: Doing right
50a0f93 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: Doing right 2
2fc299c 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: Doing right 3
385f492 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: Doing right 4
0acc87a 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: Doing right 5
36da266 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: Doing right 6
b83444f 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: Doing right 7
eefc205 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
0a8c215 
hyperledger#3055

Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: Doing right new
31a7bd6 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
c5ba16d 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
67439a8 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
2fdb629 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
8ce2d61 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
cf52907 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 9, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
eaac4ce 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 10, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
8df0979 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 10, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
a7cac9a 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 13, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
836b3df 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 13, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
3dacb53 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 14, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
653171e 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Retssaze added a commit to Retssaze/iroha that referenced this issue Feb 14, 2023
@Retssaze
[refactor] hyperledger#2123: use Algorithm for storing digest function
f206054 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
appetrosyan pushed a commit to Retssaze/iroha that referenced this issue Feb 17, 2023
@Retssaze @appetrosyan
[refactor] hyperledger#2123: use Algorithm for storing digest function
6ce961e 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
appetrosyan pushed a commit to Retssaze/iroha that referenced this issue Mar 2, 2023
@Retssaze @appetrosyan
[refactor] hyperledger#2123: use Algorithm for storing digest function
386cfb3 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
appetrosyan pushed a commit that referenced this issue Mar 2, 2023
@Retssaze @appetrosyan
[refactor] #2123: use Algorithm for storing digest function
55618c8 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Erigara pushed a commit to Erigara/iroha that referenced this issue Mar 3, 2023
@Retssaze @Erigara
[refactor] hyperledger#2123: use Algorithm for storing digest function
81ada58 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
Erigara added a commit to Erigara/iroha that referenced this issue Mar 3, 2023
@Erigara
[fix] hyperledger#2123: Return PublicKey de/serialization from mult…
c8e8ea9 
…ihash

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Mar 3, 2023
@Erigara
[fix] hyperledger#2123: Return PublicKey de/serialization from mult…
64a0d90 
…ihash

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Mar 3, 2023
@Erigara
[fix] hyperledger#2123: Return PublicKey de/serialization from mult…
176f49c 
…ihash

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Mar 3, 2023
@Erigara
[fix] hyperledger#2123: Return PublicKey de/serialization from mult…
29be808 
…ihash

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara mentioned this issue Mar 3, 2023
Merged
Erigara added a commit to Erigara/iroha that referenced this issue Mar 6, 2023
@Erigara
[fix] hyperledger#2123: Return PublicKey de/serialization from mult…
d769635 
…ihash

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit that referenced this issue Mar 6, 2023
@Erigara
[fix] #2123: Return PublicKey de/serialization from multihash
2e7d906 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara closed this as completed Mar 6, 2023
appetrosyan pushed a commit that referenced this issue Jun 5, 2023
@Retssaze @appetrosyan
[refactor] #2123: use Algorithm for storing digest function
ac8423d 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
appetrosyan pushed a commit that referenced this issue Jun 5, 2023
@Erigara @appetrosyan
[fix] #2123: Return PublicKey de/serialization from multihash
19466b4 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic pushed a commit that referenced this issue Oct 17, 2023
@Retssaze @mversic
[refactor] #2123: use Algorithm for storing digest function
60ef84a 
Signed-off-by: Retssaze <Retssaze@GMail.Com>
mversic pushed a commit that referenced this issue Oct 17, 2023
@Erigara @mversic
[fix] #2123: Return PublicKey de/serialization from multihash
607c097 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@appetrosyan @Erigara @mversic @0xt3j4s @Retssaze