Validate item names/ids without allocating Vec

[Erigara]

We have a few places where we allocate a vector within the FromStr implementation for an element name/id when we don't really need to.

Approach without allocation: data_model/src/trigger/mod.rs impl FromStr for Id.

[appetrosyan]

https://docs.rs/zerocopy/latest/zerocopy/ Might be useful

[Retssaze]

Where this data_model/src/trigger/mod.rs is located?

[appetrosyan]

Hi! This is an iroha version 2 issue, so you need to switch to the iroha2-dev branch.

[Retssaze]

Let's cath up

[fofyou]

@appetrosyan zerocopy make sense on packat deserialization from network bytes, but how can it do validation on invalid input? for example, no @ in account_id(which should have format like name@domain_name).

after look at data_model/src/trigger/mod.rs, we can do it just replace

let vector: Vec<&str> = string.split('@').collect();

with

let mut split = s.split('@');
match (split.next(), split.next(), split.next()) {

That`s right?

[Erigara]

@suiwenfeng, yes, this was my initial idea.

[fofyou]

Ok, i will refactor such code. Method execution time did improved in my local benchmark.

[Erigara]

Great to hear! Will be waiting for the PR.

[Retssaze]

I would like to do it

[fofyou]

#3003

[Retssaze]

#3003

You took my task, what a shame!

[6r1d]

While I am not sure it helps, there's a list of several issues that may be interesting for the new contributors.

[Erigara]

For example you can take a look at #2123.

[Retssaze]

To suiwenfeng: Sir, For sure you are very strong and quick, and a message above by 6r1d is definitely not only for you!