New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion]: Consider changes in MAX_MESSAGE_LENGTH
#2764
Comments
We can make an exception for genesis. But keep the limit. Otherwise I think we should change it to a mandatory configuration parameter that is either a non-zero size in MB, or no limit. The user should be the one deciding, but we need to give good docs. Ideally it should say: "if you want to be on the safe side, set it to 0, examine your network, and then set it to double the largest block". And that "running without a limit opens you up to a DoS attack". |
@appetrosyan, I'm not sure that making exception for genesis is feasible solution, this check happens on another abstraction layer where iroha doesn't make distinction between messages it send. I agree with configuration parameter approach it could be smt like |
Was decided to remove this constraint at all as short term solution, long term solution would be introduction of bootstrap peers and hot reloading. |
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
With large enough
Genesis
we cant send it through network to other peers through network.Options:
The text was updated successfully, but these errors were encountered: