Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #2764: Remove limit on max message size #2769

Merged

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Sep 21, 2022

Signed-off-by: Shanin Roman shanin1000@yandex.ru

Description of the Change

Remove restriction on max message size (remove MAX_MESSAGE_LEN constant and checks associated with it).

Issue

Closes #2764.

Benefits

Not it's possible to send large genesis block through network.

Possible Drawbacks

Malicious peer could try to ddos other peers.

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 21, 2022
@Erigara Erigara self-assigned this Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #2769 (97582fb) into iroha2-dev (a16d9c3) will decrease coverage by 1.94%.
The diff coverage is 66.85%.

@@              Coverage Diff               @@
##           iroha2-dev    #2769      +/-   ##
==============================================
- Coverage       67.61%   65.66%   -1.95%     
==============================================
  Files             140      166      +26     
  Lines           26173    29907    +3734     
==============================================
+ Hits            17696    19638    +1942     
- Misses           8477    10269    +1792     
Impacted Files Coverage Δ
actor/src/actor_id.rs 90.00% <ø> (ø)
actor/src/deadlock.rs 100.00% <ø> (ø)
cli/derive/src/lib.rs 92.30% <ø> (+17.58%) ⬆️
cli/src/event.rs 41.86% <ø> (ø)
cli/src/main.rs 1.09% <0.00%> (-0.26%) ⬇️
cli/src/stream.rs 81.39% <ø> (ø)
cli/src/torii/mod.rs 28.88% <0.00%> (ø)
client/src/http.rs 47.82% <ø> (ø)
client/src/http_default.rs 41.59% <ø> (-18.59%) ⬇️
client_cli/src/main.rs 0.27% <0.00%> (+0.01%) ⬆️
... and 213 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@appetrosyan appetrosyan merged commit 6932cde into hyperledger:iroha2-dev Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants