Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in peer start up #1392

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

e-ivkov
Copy link
Contributor

@e-ivkov e-ivkov commented Sep 1, 2021

Signed-off-by: Egor Ivkov e.o.ivkov@gmail.com

Description of the Change

Closes #1386
Closes #1390

  • Allows loading genesis public key only from env
  • config, genesis and trusted_peers path can now be specified in cli params

CLI now:

USAGE:
    iroha_cli [FLAGS] [OPTIONS]

FLAGS:
    -h, --help              Prints help information
        --submit-genesis    Set this flag on the peer that should submit genesis on the network initial start
    -V, --version           Prints version information

OPTIONS:
        --config-path <config-path>                  Set custom config file path [default: config.json]
        --genesis-path <genesis-path>                Set custom genesis file path [default: genesis.json]
        --trusted-peers-path <trusted-peers-path>    Set custom trusted peers file path [default: trusted_peers.json]

@e-ivkov e-ivkov self-assigned this Sep 1, 2021
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 1, 2021
@e-ivkov e-ivkov force-pushed the ops-fixes branch 3 times, most recently from 03922f2 to 5b446e9 Compare September 1, 2021 18:45
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1392 (72ce08a) into iroha2-dev (a034459) will decrease coverage by 0.00%.
The diff coverage is 71.68%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1392      +/-   ##
==============================================
- Coverage       75.33%   75.33%   -0.01%     
==============================================
  Files             121      121              
  Lines           17525    17560      +35     
==============================================
+ Hits            13203    13229      +26     
- Misses           4322     4331       +9     
Impacted Files Coverage Δ
iroha/src/config.rs 94.96% <ø> (+2.00%) ⬆️
iroha/test_network/tests/sumeragi_with_mock.rs 0.25% <0.00%> (-0.01%) ⬇️
iroha_cli/src/main.rs 7.14% <0.00%> (+3.69%) ⬆️
iroha_client/tests/restart_peer.rs 100.00% <ø> (ø)
iroha/src/lib.rs 79.31% <51.72%> (-6.87%) ⬇️
iroha/test_network/src/lib.rs 80.32% <84.61%> (-0.01%) ⬇️
iroha/src/genesis.rs 98.05% <100.00%> (+0.13%) ⬆️
iroha/src/init.rs 100.00% <100.00%> (ø)
iroha/src/tx.rs 85.47% <100.00%> (ø)
iroha_dsl/tests/dsl.rs 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a034459...72ce08a. Read the comment docs.

Revertron
Revertron previously approved these changes Sep 2, 2021
i1i1
i1i1 previously approved these changes Sep 2, 2021
- Allows loading genesis public key only from env
- config, genesis and trusted_peers path can now be specified in cli params

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
@e-ivkov e-ivkov merged commit 326ff44 into hyperledger:iroha2-dev Sep 2, 2021
@e-ivkov e-ivkov deleted the ops-fixes branch October 18, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants