Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #2013: Hotfix CLI args. #2014

Merged
merged 6 commits into from
Mar 30, 2022

Conversation

appetrosyan
Copy link
Contributor

Signed-off-by: Aleksandr a-p-petrosyan@yandex.ru

Description of the Change

  • Accept empty args which are sometimes passed by exec.
  • Fixed CI coverage workflow.
  • Generate changelog for the March Release

Issue

Closes #2013

Benefits

Changelog, working CLI args, working push workflow.

Possible Drawbacks

None

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #2014 (23a43f2) into iroha2-dev (85d881c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           iroha2-dev    #2014      +/-   ##
==============================================
- Coverage       77.95%   77.93%   -0.02%     
==============================================
  Files             176      176              
  Lines           23982    23982              
==============================================
- Hits            18694    18690       -4     
- Misses           5288     5292       +4     
Impacted Files Coverage Δ
cli/src/main.rs 2.27% <0.00%> (ø)
crypto/src/signature.rs 85.04% <0.00%> (-2.00%) ⬇️
core/src/block_sync.rs 89.15% <0.00%> (-1.21%) ⬇️
core/src/kura.rs 93.90% <0.00%> (-0.18%) ⬇️
core/src/sumeragi/fault.rs 83.39% <0.00%> (+0.18%) ⬆️
core/src/sumeragi/message.rs 88.47% <0.00%> (+0.26%) ⬆️
core/src/sumeragi/network_topology.rs 96.38% <0.00%> (+0.55%) ⬆️
tools/kura_inspector/src/print.rs 96.92% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d881c...23a43f2. Read the comment docs.

s8sato
s8sato previously approved these changes Mar 28, 2022
s8sato
s8sato previously approved these changes Mar 28, 2022
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
…feature set.

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan merged commit adf1ad8 into hyperledger:iroha2-dev Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants