[refactor] Validate item names/ids without allocating Vec #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenfeng Sui <suiwenfeng@qq.com>
fofyou
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev and
Erigara
as code owners
github-actions
bot
added
the
iroha2-dev
6r1d
reviewed
Dec 9, 2022
Erigara
reviewed
Dec 9, 2022
There was a problem hiding this comment.
Good job!
Here few minor things you should do:
- We use standardize format for commit names, so you commit message should look like:
[refactor] #2675: Validate item names/ids without allocating Vec. - Also we use
rustfmtin our workflow , you can run it by following command:cargo +nightly fmt --all
| assert!(account_empty.is_err()); | ||
|
|
||
| let account_invalid: Result<AccountId, _> = "testhello".parse(); | ||
| assert!(account_invalid.is_err()); |
There was a problem hiding this comment.
Wight be redundant but we can also test for string "@".
There was a problem hiding this comment.
i reopened a pr for some reason, you have to check this at #3004 now.
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3003 +/- ##
==============================================
- Coverage 67.61% 62.47% -5.14%
==============================================
Files 140 169 +29
Lines 26173 30948 +4775
==============================================
+ Hits 17696 19334 +1638
- Misses 8477 11614 +3137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Wenfeng Sui suiwenfeng@qq.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenfeng Sui suiwenfeng@qq.com
Description of the Change
Issue
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]