An expression statement should be followed by ;

[seanyoung]

Fixes #1600

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99ecfc0) 88.00% compared to head (053d9e4) 88.00%.

❗ Current head 053d9e4 differs from pull request most recent head d074f3d. Consider uploading reports for the commit d074f3d to get more accurate results

Files	Patch %	Lines
solang-parser/src/helpers/fmt.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
- Coverage   88.00%   88.00%   -0.01%     
==========================================
  Files         133      133              
  Lines       64959    64961       +2     
==========================================
  Hits        57167    57167              
- Misses       7792     7794       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[seanyoung]

The coverage report says this is not tested, but it is. It works when I run cargo llvm-cov --all-features --workspace locally, even if I remove the temporary files. I would not be surprised if codecov cannot deal with crates properly.

[xermicus]

I feel like it's becoming inevitable to honor solc version pragmas

[seanyoung]

I feel like it's becoming inevitable to honor solc version pragmas

Actually #1592 switches behaviour based on the version pragma

[LucasSte]

The coverage report says this is not tested, but it is. It works when I run cargo llvm-cov --all-features --workspace locally, even if I remove the temporary files. I would not be surprised if codecov cannot deal with crates properly.

I think the cargo llvm-cov is misconfigured. Solana's repository consists of multiple crates and codecov works properly. Please, note that codecov is just a tool to visualize and store the coverage reports. If it is showing wrong results, it is because we are sending an incorrect report to it.