Bump polkadot node version #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
…dot where the runtime now logs the API calls and return codes Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
LucasSte
approved these changes
Jan 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
- Coverage 88.44% 88.43% -0.02%
==========================================
Files 150 150
Lines 68322 68200 -122
==========================================
- Hits 60429 60311 -118
+ Misses 7893 7889 -4 ☔ View full report in Codecov by Sentry. |
seanyoung
approved these changes
Jan 11, 2024
| @@ -3,6 +3,7 @@ import { weight, createConnection, deploy, transaction, aliceKeypair, daveKeypai | |||
| import { ContractPromise } from '@polkadot/api-contract'; | |||
| import { ApiPromise } from '@polkadot/api'; | |||
|
|
|||
|
|
|||
src/emit/polkadot/storage.rs
Outdated
| log_return_code(binary, "seal_get_storage", exists); | ||
|
|
||
| let exists = binary.builder.build_int_compare( | ||
| let condition = binary.builder.build_int_compare( |
There was a problem hiding this comment.
exists was supposed to mean "does the key exist". condition is not very clear
src/emit/polkadot/target.rs
Outdated
| log_return_code(binary, "seal_get_storage: ", exists); | ||
|
|
||
| let exists = binary.builder.build_int_compare( | ||
| let condition = binary.builder.build_int_compare( |
There was a problem hiding this comment.
exists was supposed to mean "does the key exist". condition is not very clear
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the Polkadot node. In recent versions, the node (in debug mode) logs any API calls and their results to debug buffer on its own. Because this feature was only relevant in the Polkadot target, I 🪓 it.