Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs for pub/sub related classes and methods #768

Closed
wants to merge 1 commit into from

Conversation

mushketyk
Copy link
Contributor

What does this PR do?

Adds documentation for new pub/sub functionality in web3j implemented in #458

Where should the reviewer start?

Just go through new documentation in getting_started.rst

Why is it needed?

To allow users to quickly start working with pub/sub functionality in web3j.

@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #768 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #768      +/-   ##
============================================
- Coverage     77.38%   77.23%   -0.15%     
+ Complexity     1851     1848       -3     
============================================
  Files           241      241              
  Lines          6814     6814              
  Branches       1012     1012              
============================================
- Hits           5273     5263      -10     
- Misses         1291     1300       +9     
- Partials        250      251       +1
Impacted Files Coverage Δ Complexity Δ
...n/java/org/web3j/protocol/core/filters/Filter.java 53.12% <0%> (-14.07%) 8% <0%> (-2%)
core/src/main/java/org/web3j/utils/Flowables.java 80% <0%> (-4%) 9% <0%> (-1%)
...org/web3j/protocol/websocket/WebSocketService.java 85.26% <0%> (-1.06%) 50% <0%> (-1%)
.../main/java/org/web3j/protocol/rx/JsonRpc2_0Rx.java 74.07% <0%> (+2.46%) 26% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6160282...3bdde76. Read the comment docs.

@snazha-blkio snazha-blkio added this to the 4.0.0-alpha-2 milestone Nov 6, 2018
@snazha-blkio snazha-blkio self-assigned this Nov 13, 2018
@snazha-blkio snazha-blkio added the needs-review issue/PR needs review from maintainer label Nov 14, 2018
@snazha-blkio snazha-blkio added the duplicate issue/PR is a duplicate of another issue/PR label Nov 16, 2018
@snazha-blkio
Copy link
Contributor

Hi @mushketyk

Thanks for your hard work, we created a branch off your PR and some minor tweaks, given that we couldn't make changes to your PR.

This has been merged and can be found here: #791

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate issue/PR is a duplicate of another issue/PR needs-review issue/PR needs review from maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants