fix: unnecessary loadInstance call

hypermedia-app · Nov 23, 2022 · bc4128b · bc4128b
1 parent 6a42cdf
commit bc4128b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/nine-years-lick.md b/.changeset/nine-years-lick.md
@@ -0,0 +1,5 @@
+---
+"@hydrofoil/shaperone-wc-shoelace": patch
+---
+
+When an autocomplete was populated on load, it would unnecessarily call `loadInstance` upon selection
diff --git a/packages/wc-shoelace/components/autocomplete.ts b/packages/wc-shoelace/components/autocomplete.ts
@@ -79,10 +79,10 @@ export const autocomplete: Lazy<AutoCompleteEditor> & Options = {
   initLabel(this: AutoCompleteEditor, { property: { shape }, value, updateComponentState }) {
     const {
       object,
-      componentState: { freetextQuery, selectionLoading },
+      componentState: { freetextQuery, selectionLoading, selected },
     } = value
 
-    if (object && !freetextQuery && !selectionLoading) {
+    if (object && !selected && !freetextQuery && !selectionLoading) {
       const selectionLoading = this.loadInstance({ property: shape, value: object })
         .then((resource) => {
           updateComponentState({