Feature/config for json serialization #43
Conversation
|
By analyzing the blame information on this pull request, we identified @vadymmarkov to be a potential reviewer |
| @@ -1,10 +1,19 @@ | |||
| import Foundation | |||
|
|
|||
| /// A configuration struct | |||
| public struct CacheJSONOptions { | |||
There was a problem hiding this comment.
@zenangst Can it be just JSONOptions ?
There was a problem hiding this comment.
@zenangst Could it be an enum?
There was a problem hiding this comment.
Yeah we could totally do that! 😁
There was a problem hiding this comment.
@onmyway133 I added the namespace to scope it as it is global.
There was a problem hiding this comment.
@zenangst it is OK
Although every "global" is actually under the framework namespace 😬
There was a problem hiding this comment.
That is actually true!
|
@vadymmarkov @onmyway133 is it okay now? |
|
@zenangst Please roll back to |
|
@vadymmarkov oh you! :) |
This reverts commit cb9b524.
|
Done |
|
I got it wrong, thought it like a wrapper, but actually it's a config. |
|
No worries 😁 |
This PR adds configuration options for NSJSONSerialization.
It can be configured like this;