Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace imaginary with kingfisher library #284

Closed
naveedmcs opened this issue Feb 14, 2022 · 3 comments · Fixed by #287
Closed

replace imaginary with kingfisher library #284

naveedmcs opened this issue Feb 14, 2022 · 3 comments · Fixed by #287

Comments

@naveedmcs
Copy link

for performance improvements of loading images .
I want to replace imaginary library to kingfisher library. what is possible solutions?

@chickdan
Copy link

It looks like PR #283 switched image loading libraries.

That said I'd like to suggest that Lightbox be refactored in a way that allows developers to choose their own image loading library rather than forcing dependencies. For example I don't use SDWebImage or Kingfisher and instead use Nuke.

@naveedmcs
Copy link
Author

@chickdan Thanks for reply. how can i use this PR in my project? Please guide me. i will be very Thank full to you.

@mohpor
Copy link

mohpor commented Feb 21, 2022

@chickdan Dependency injection is what we need here. and I seriously second this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants