Remove dependencies on specific image request library #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @3lvis, Could you please consider merging this in soon? We're still using Cache+Imaginary over here, and are leaning toward using this library. Thanks! |
|
@nlash-livly Merged. Thanks @kitwtnb! |
kitwtnb
deleted the
remove-dependency-on-specific-image-request-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #284 .
Since it is undesirable to depend on a specific image library, removed
SDWebImagedependency.If developers use
LightboxImage(imageURL:), they must also implementLightboxConfig.loadImageat the same time.The same behavior as before can be achieved by using any image library in
LightboxConfig.loadImage.