Update shout view to increase larger touch area #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onmyway133, thanks for your PR! By analyzing the history of the files in this pull request, we identified @RamonGilabert, @tkohout and @LucidityDesign to be potential reviewers. |
onmyway133
commented
Nov 21, 2016
| [indicatorView, imageView, titleLabel, subtitleLabel, gestureContainer].forEach { | ||
| backgroundView.addSubview($0) } | ||
| [imageView, titleLabel, subtitleLabel, indicatorView].forEach { | ||
| $0.autoresizingMask = [] |
There was a problem hiding this comment.
I don't think we need autoresizing, so explicitly disable it
onmyway133
commented
Nov 21, 2016
| frame = CGRect(x: 0, y: 0, width: width, height: 0) | ||
| backgroundView.frame = CGRect(x: 0, y: 0, width: width, height: 0) | ||
|
|
||
| frame.size.height = 0 |
There was a problem hiding this comment.
Reset to 0 to make the animation happen
onmyway133
commented
Nov 21, 2016
| @@ -86,15 +79,18 @@ open class ShoutView: UIView { | |||
| open fileprivate(set) var completion: (() -> ())? | |||
|
|
|||
| private var subtitleLabelOriginalHeight: CGFloat = 0 | |||
| private var internalHeight: CGFloat = 0 | |||
There was a problem hiding this comment.
This is the height of the visible view
onmyway133
commented
Nov 21, 2016
| UIView.animate(withDuration: 0.2, animations: { | ||
| self.frame.size.height = height + Dimensions.touchOffset | ||
| }, completion: { _ in | ||
| if translation.y < -5 { |
There was a problem hiding this comment.
Each statement in each line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frame didSet, make it easy to reason about the code