Extended whisper background height to embrace the notch #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on the iPhoneX notch space
|
@gilserrap Thanks for the PR, I think this is an acceptable solution for now |
|
You're welcome! |
jondwillis
reviewed
Nov 21, 2017
| public struct Dimensions { | ||
|
|
||
| static var notchHeight: CGFloat { | ||
| if UIApplication.shared.statusBarFrame.height > 20 { |
There was a problem hiding this comment.
Would it be better to use safeAreaInsets here, if available?
|
This has the disadvantage of covering the status bar on iPhone X, which is not necessary. |
|
@jondwillis You're right, I am not comfortable with this solution. |
|
See my comment on: |
|
@jondwillis Hi, I've made the change regarding the window level, you can check https://github.com/hyperoslo/Whisper/releases/tag/6.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, I guess there's no perfect solution, but what would you think of having the whistles display all the way from the top of the screen on the iPhone X?