Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added temporary validation for EcdsaSecp256k1VerificationKey2019 VM type to allow duplicate publicKeyMultibase only when blockchainAccountIds are provided #349

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix: added temporary validation for EcdsaSecp256k1VerificationKey2019 VM type to allow duplicate publicKeyMultibase only when blockchainAccountIds are provided #349

merged 1 commit into from
Mar 22, 2023

Conversation

arnabghose997
Copy link
Contributor

Closes: #348

Following Cases are covered in this PR:

Scenario Whether it should PASS or FAIL ?
Registering a DID with two VM of type EcdsaSecp256k1VerificationKey2019 with duplicate publicKeyMultibase and different blockchain account Id PASS
Registering a DID with two VM of type EcdsaSecp256k1VerificationKey2019 with duplicate publicKeyMultibase but one of them is without a blockchain account id PASS
Registering a DID with two VM of type EcdsaSecp256k1VerificationKey2019 with duplicate publicKeyMultibase and duplicate blockchainAccountId FAIL
Registering a DID with two VM of type EcdsaSecp256k1VerificationKey2019 with duplicate publicKeyMultibase and no blockchainAccountId in either of them FAIL
User tries to register a DID Document with duplicate publicKeyMultibase of type Ed25519VerificationKey2020 FAIL

@arnabghose997
fix: added temporary validation for EcdsaSecp256k1VerificationKey2019…
348d56b 
… type to allow duplicate publicKeyMultibase only when blockchainAccountIds are provided
@arnabghose997 arnabghose997 self-assigned this Mar 22, 2023
@arnabghose997 arnabghose997 merged commit 0369721 into develop Mar 22, 2023
@arnabghose997 arnabghose997 deleted the 348-duplicate-publickeymultibase-error branch May 3, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vishwas1 Vishwas1 Vishwas1 approved these changes

Assignees

@arnabghose997 arnabghose997

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnabghose997 @Vishwas1