Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Defined rules for method-specific-id #353

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Feat: Defined rules for method-specific-id #353

merged 3 commits into from
Apr 21, 2023

Conversation

arnabghose997
Copy link
Contributor

The PR aims to solidify the standard for method-specific-id formats.

The supported formats are:

  • CAIP-10 Blockchain Account ID:

    • Example: did:hid:testnet:cosmos:osmosis-1:osmo1f6r0x3pljpl7pe76zzv36l0ksztqmdltakhv4r, did:hid:testnet:eip155:1:0xF4eE129BEDE6ac5E870bCf972e74A117b4809df9
    • While Registering a DID Document with this method-specific-id format, a verification method corresponding to the method-specific-id's blockchain address MUST be provided to prove the ownership.

  • String ID consisting of alphanumeric, dot(.) and hyphen (-) characters

    • This is done to accommodate ID formats such as UUID, ENS like domans, etc.
    • Unlike former format type, this does not require any ownership proof

@arnabghose997 arnabghose997 self-assigned this Apr 19, 2023
@arnabghose997 arnabghose997 added enhancement New feature or request ssi labels Apr 19, 2023
Vishwas1
Vishwas1 reviewed Apr 20, 2023
View reviewed changes
x/ssi/types/utils.go Outdated Show resolved Hide resolved
Vishwas1
Vishwas1 reviewed Apr 20, 2023
View reviewed changes
x/ssi/types/utils.go Outdated Show resolved Hide resolved
Vishwas1
Vishwas1 requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@Vishwas1 Vishwas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update

@arnabghose997
refactor: changed the names of getMSIBlockchainAccountIdCondition and…
2d8b27d 
… getMSINonBlockchainAccountIdCondition to isMSIBlockchainAccountId and isMSINonBlockchainAccountId respectively since they return boolean conditions; fixed comment of isMSIBlockchainAccountId
@arnabghose997 arnabghose997 merged commit 597964b into develop Apr 21, 2023
@arnabghose997 arnabghose997 deleted the method-specific-id-rules-impl branch April 21, 2023 04:30
@arnabghose997 arnabghose997 linked an issue May 3, 2023 that may be closed by this pull request
Proper format for method-specific-id of DID Identifier #206
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vishwas1 Vishwas1 Vishwas1 approved these changes

Assignees

@arnabghose997 arnabghose997

Labels
enhancement New feature or request ssi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper format for method-specific-id of DID Identifier
2 participants
@arnabghose997 @Vishwas1