Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for X25519KeyAgreementKey2020 and X25519KeyAgreementKeyEIP5630 based keys #363

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

arnabghose997
Copy link
Contributor

@arnabghose997 arnabghose997 commented Jul 20, 2023

This PR aims to introduce support for X25519KeyAgreementKey2020 and X25519KeyAgreementKeyEIP5630 verification method types

These keys are based on keyAgreement attribute. Hence, any verification method of these types can only be part of the keyAgreement attribute only, and hence they are not allowed to be used for Authentication as well as Assertion purposes. This also means that Ed25519VerificationKey2020 based Verification Methods cannot be used for keyAgreement Purposes

Test Cases:

  1. FAIL: Ed25519VerificationKey2020 based Verification Method ID being added to keyAgreement attribute

  2. FAIL: X25519KeyAgreementKey2020 based Verification Method ID being added to authentication attribute

  3. PASS: A DID Document is created with Ed25519VerificationKey2020 and X25519KeyAgreementKey2020 based VMs

  4. FAIL: An attempt is made to update the DID Document by passing the signature of X25519KeyAgreementKey2020 based verification method

  5. PASS: An attempt is made to update the DID Document by passing the signature of Ed25519VerificationKey2020 based verification method

  6. FAIL: An attempt is made to deactivate the DID Document by passing the signature of X25519KeyAgreementKey2020 based verification method

  7. PASS: An attempt is made to deactivate the DID Document by passing the signature of Ed25519VerificationKey2020 based verification method

@arnabghose997 arnabghose997 added enhancement New feature or request ssi labels Jul 20, 2023
@arnabghose997 arnabghose997 self-assigned this Jul 20, 2023
@arnabghose997 arnabghose997 changed the title Support for X25519KeyVerificationKey2020 and X25519KeyAgreementKeyEIP5630 based keys Support for X25519KeyAgreementKey2020 and X25519KeyAgreementKeyEIP5630 based keys Jul 20, 2023
@arnabghose997 arnabghose997 merged commit 5e6e330 into develop Jul 20, 2023
2 checks passed
@arnabghose997 arnabghose997 deleted the key-agreement-support branch July 20, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ssi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants