Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

[Enhancement request] Granular control for notification badge #3

Closed
alicerunsonfedora opened this issue Apr 18, 2019 · 1 comment · Fixed by #6
Closed

[Enhancement request] Granular control for notification badge #3

alicerunsonfedora opened this issue Apr 18, 2019 · 1 comment · Fixed by #6
Labels
enhancement New feature or request

Comments

@alicerunsonfedora
Copy link
Member

Currently, the notification badge forcibly shows new notifications when the app receives a new one without accounting for any existing ones that the user might not have seen before. I often find myself opening the notifications panel time and time again because I don't see anything for new notifications.

There should be a new setting that dictates what the badge will display:

  • The total notifications on the server
  • Only new notifications

This might be toggled as a user string under the setting displayOnNotificationBadge with either a string or the type "all" | "new". In theory, this could probably be done as a bool so that it works with setUserDefaultBool and getUserDefaultBool.

@alicerunsonfedora
Copy link
Member Author

The setting is now implemented with a boolean key, displayAllOnNotificationBadge. The setting is also located under "Notifications":

Screen Shot 2019-04-19 at 14 58 05

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant