Remove deprecation Bruker, EMD, Nexus #30
Conversation
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 82.67% 82.73% +0.06%
==========================================
Files 40 40
Lines 8050 8032 -18
Branches 1819 1857 +38
==========================================
- Hits 6655 6645 -10
+ Misses 924 920 -4
+ Partials 471 467 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
CHANGES.rst
Outdated
| @@ -8,6 +8,20 @@ https://rosettasciio.readthedocs.io/en/latest/changes.html | |||
|
|
|||
| .. towncrier release notes start | |||
|
|
|||
| API Removal | |||
| ----------- | |||
There was a problem hiding this comment.
As this is relevant to hyperpsy users and the API was in hyperspy before, would it be better to move it to the corresponding entry of hyperpsy 2.0 changelog?
There was a problem hiding this comment.
Good point, we might want to just duplicate it there, in case migrating HyperSpy users end up looking here?
There was a problem hiding this comment.
There was a problem hiding this comment.
I still find odd to have a API removal section for a first release! I would remove this section and a normal changelog entry - the description on its own is good.
There was a problem hiding this comment.
I moved it to a regular towncrier entry for the PR and checked the formatting locally.
Description of the change
Remove deprecated keywords and attributes from readers before first release (which will be the one used by HyperSpy 2.0, for which these deprecations were announced).
Closes #24
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),readthedocsdoc build of this PR (link in github checks)