Ng 16 (#2341)

* feat: upgrade to v15 * refactor: fix build failure * refactor: update service * refactor: updating tsconfig * refactor: revert post install * feat: upgrade to v16 * refactor: test fixes * refactor: test fixes * refactor: fix lint * refactor: fix lint errors * refactor: using route functions * refactor: fix test * refactor: adding selectors
hypertrace · Dec 13, 2023 · 44f1d65 · 44f1d65
1 parent e9a8dff
commit 44f1d65
Show file tree

Hide file tree

Showing 28 changed files with 16,659 additions and 17,369 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -16,10 +16,9 @@
         "createDefaultProgram": true
       },
       "extends": [
-        "plugin:@angular-eslint/ng-cli-compat",
-        "plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@angular-eslint/recommended",
         "plugin:@angular-eslint/template/process-inline-templates",
-        "plugin:@typescript-eslint/all",
         "prettier"
       ],
       "plugins": ["eslint-plugin-no-null", "eslint-plugin-unicorn"],
@@ -56,7 +55,6 @@
         "@angular-eslint/use-component-view-encapsulation": "error",
         "@typescript-eslint/await-thenable": "error",
         "@typescript-eslint/ban-ts-comment": "error",
-        "@typescript-eslint/consistent-type-definitions": "error",
         "@typescript-eslint/explicit-member-accessibility": [
           "error",
           {
@@ -88,7 +86,6 @@
         "@typescript-eslint/no-this-alias": "error",
         "@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
         "@typescript-eslint/no-unnecessary-qualifier": "error",
-        "@typescript-eslint/no-unnecessary-type-arguments": "error",
         "@typescript-eslint/no-unnecessary-type-assertion": "error",
         "@typescript-eslint/no-var-requires": "error",
         "@typescript-eslint/prefer-readonly": "error",
@@ -99,21 +96,20 @@
             "allowTemplateLiterals": true
           }
         ],
-        "@typescript-eslint/require-await": "error",
-        "@typescript-eslint/restrict-plus-operands": "error",
-        "no-console": ["error", {
-          "allow": ["warn","error"]
-        }],
-        "arrow-body-style": ["error", "as-needed"],
-        "complexity": ["error", 20],
+        "arrow-body-style": [
+          "error",
+          "as-needed"
+        ],
+        "complexity": [
+          "error",
+          30
+        ],
         "default-case": "error",
         "eqeqeq": [
           "error",
           "always"
         ],
-        "import/no-default-export": "error",
         "import/no-internal-modules": "off",
-        "import/no-unassigned-import": "error",
         "max-classes-per-file": [
           "error",
           1
@@ -181,11 +177,20 @@
         "no-useless-constructor": "off",
         "no-underscore-dangle": "off",
         "jsdoc/newline-after-description": "off",
+        "no-console": [
+          "error",
+          {
+            "allow": [
+              "warn",
+              "error"
+            ]
+          }
+        ],
         "@typescript-eslint/array-type": "off",
         "@typescript-eslint/prefer-regexp-exec": "off",
         "@typescript-eslint/parameter-properties": "off",
         "@typescript-eslint/consistent-type-exports": "off",
-        "@typescript-eslint/no-redundant-type-constituents":"off",
+        "@typescript-eslint/no-redundant-type-constituents": "off",
         "@typescript-eslint/promise-function-async": "off",
         "@typescript-eslint/restrict-template-expressions": "off",
         "@typescript-eslint/no-confusing-void-expression": "off",
@@ -214,7 +219,10 @@
         "@typescript-eslint/no-non-null-asserted-optional-chain": "off",
         "@typescript-eslint/no-unsafe-argument": "off",
         "@typescript-eslint/no-non-null-assertion": "off",
-        "@typescript-eslint/semi": ["off", null],
+        "@typescript-eslint/semi": [
+          "off",
+          null
+        ],
         "@typescript-eslint/type-annotation-spacing": "off",
         "@typescript-eslint/unbound-method": "off",
         "@typescript-eslint/init-declarations": "off",
@@ -230,13 +238,31 @@
         "@typescript-eslint/ban-types": "off",
         "@typescript-eslint/no-unused-expressions": "off",
         "@typescript-eslint/no-inferrable-types": "off",
+        "@typescript-eslint/no-base-to-string": "off",
+        "@typescript-eslint/no-unnecessary-type-arguments": "off",
+        "@typescript-eslint/require-array-sort-compare": "off",
+        "@typescript-eslint/no-shadow": "off",
+        "@typescript-eslint/restrict-plus-operands": "off",
+        "@typescript-eslint/no-duplicate-enum-values": "off",
+        "@typescript-eslint/prefer-reduce-type-parameter": "off",
+        "@typescript-eslint/default-param-last": "off",
+        "@typescript-eslint/prefer-includes": "off",
+        "@typescript-eslint/consistent-type-definitions": "off",
+        "@typescript-eslint/no-namespace": "off",
+        "@typescript-eslint/require-await": "off",
+        "no-fallthrough": "off",
         "prefer-spread": "off",
         "no-unnecessary-class": "off",
-        "import/order": "off",
         "id-blacklist": "off",
         "init-declarations": "off",
-        "arrow-parens": ["off", "always"],
-        "brace-style": ["off", "off"],
+        "arrow-parens": [
+          "off",
+          "always"
+        ],
+        "brace-style": [
+          "off",
+          "off"
+        ],
         "class-methods-use-this": "off",
         "eol-last": "off",
         "import/no-deprecated": "off",
@@ -245,6 +271,17 @@
         "new-parens": "off",
         "newline-per-chained-call": "off",
         "no-extra-semi": "off",
+        "no-restricted-imports": [
+          "error",
+          {
+            "paths": [
+              {
+                "name": "lodash",
+                "message": "Please import from 'lodash-es' instead of 'lodash'."
+              }
+            ]
+          }
+        ],
         "no-irregular-whitespace": "off",
         "no-magic-numbers": "off",
         "no-plusplus": [
@@ -275,7 +312,7 @@
         "@angular-eslint/template/cyclomatic-complexity": [
           "error",
           {
-            "maxComplexity": 15
+            "maxComplexity": 35
           }
         ],
         "@angular-eslint/template/use-track-by-function": "off"

diff --git a/angular.json b/angular.json
@@ -104,7 +104,13 @@
         "lint": {
           "builder": "@angular-eslint/builder:lint",
           "options": {
-            "lintFilePatterns": ["/**/*.ts", "**/*.html"]
+            "lintFilePatterns": [
+              "src/**/*.ts",
+              "src/**/*.html",
+              "projects/**/!(*.(d)).ts",
+              "projects/**/*.html",
+              "*.ts"
+            ]
           }
         }
       }

diff --git a/jest.config.debug.js b/jest.config.debug.js
@@ -5,15 +5,14 @@ process.env.TZ = 'UTC'; // Tests should always run in UTC, no time zone dependen
 
 // eslint-disable-next-line no-undef
 globalThis.ngJest = {
-  skipNgcc: false,
+  skipNgcc: true,
   tsconfig: 'tsconfig.spec.json',
 };
 
 module.exports = {
   rootDir: '.',
   preset: 'jest-preset-angular',
   setupFilesAfterEnv: ['<rootDir>/setup-jest.ts'],
-  globalSetup: 'jest-preset-angular/global-setup',
   transform: {
     '^.+\\.(ts|js|html|svg)$': [
       'jest-preset-angular',

diff --git a/jest.config.js b/jest.config.js
@@ -5,15 +5,14 @@ process.env.TZ = 'UTC'; // Tests should always run in UTC, no time zone dependen
 
 // eslint-disable-next-line no-undef
 globalThis.ngJest = {
-  skipNgcc: false,
+  skipNgcc: true,
   tsconfig: 'tsconfig.spec.json',
 };
 
 module.exports = {
   rootDir: '.',
   preset: 'jest-preset-angular',
   setupFilesAfterEnv: ['<rootDir>/setup-jest.ts'],
-  globalSetup: 'jest-preset-angular/global-setup',
   reporters: [
     'default',
     [