Ng 16 #2341
Merged
Ng 16 #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
==========================================
- Coverage 81.86% 81.69% -0.18%
==========================================
Files 928 928
Lines 20924 20787 -137
Branches 3338 3135 -203
==========================================
- Hits 17130 16981 -149
- Misses 3656 3665 +9
- Partials 138 141 +3 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| "@angular/platform-browser": "^16.1.8", | ||
| "@angular/platform-browser-dynamic": "^16.1.8", | ||
| "@angular/router": "^16.1.8", | ||
| "@apollo/client": "^3.8.5", | ||
| "@fullstory/browser": "^1.7.1", | ||
| "@hypertrace/hyperdash": "^1.2.1", |
There was a problem hiding this comment.
Suggested change
| "@hypertrace/hyperdash": "^1.2.1", | |
| "@hypertrace/hyperdash": "^1.3.0", |
| "@fullstory/browser": "^1.7.1", | ||
| "@hypertrace/hyperdash": "^1.2.1", | ||
| "@hypertrace/hyperdash-angular": "4.0.0", | ||
| "@types/d3-hierarchy": "^2.0.5", | ||
| "@hypertrace/hyperdash-angular": "^5.1.0", |
There was a problem hiding this comment.
Suggested change
| "@hypertrace/hyperdash-angular": "^5.1.0", | |
| "@hypertrace/hyperdash-angular": "^5.2.0", |
There was a problem hiding this comment.
can we do it separately? Just in case the new hd version leads to any UI issues.
| "no-console": [ | ||
| "error", | ||
| { | ||
| "allow": [ |
There was a problem hiding this comment.
Are you sure we want this? We might be better off leaving it to loggerService.
There was a problem hiding this comment.
This already exists. See above. I think the tool has re-arranged the rules.
jake-bassett
previously approved these changes
Dec 12, 2023
jake-bassett
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.