Metrics followup #123
Merged
Metrics followup #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
============================================
- Coverage 81.21% 81.11% -0.11%
+ Complexity 573 569 -4
============================================
Files 53 53
Lines 2204 2192 -12
Branches 234 235 +1
============================================
- Hits 1790 1778 -12
Misses 319 319
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...rc/main/java/org/hypertrace/core/query/service/prometheus/QueryRequestToPromqlConverter.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
added 2 commits
December 14, 2021 14:31
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@rish691 As part of this PR, can you put the constraints on log4j related library coming from a third party to use the latest |
| @@ -125,12 +123,12 @@ public OkHttpResponseCallback(Request request) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void onResponse(Call call, Response response) throws IOException { | |||
| public void onResponse(@NonNull Call call, @NonNull Response response) { | |||
There was a problem hiding this comment.
why do we need explicitly @NonNull?
There was a problem hiding this comment.
IDE suggestion, it says Not annotated parameter overrides @NotNull parameter , basically this param is marked not null in the parent
...rc/main/java/org/hypertrace/core/query/service/prometheus/PrometheusBasedRequestHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/hypertrace/core/query/service/prometheus/QueryRequestToPromqlConverter.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Dec 15, 2021
Comment on lines
+137
to
+138
| ValueCase valueCase = expression.getValueCase(); | ||
| switch (valueCase) { |
There was a problem hiding this comment.
nit
Suggested change
| ValueCase valueCase = expression.getValueCase(); | |
| switch (valueCase) { | |
| switch (expression.getValueCase()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #119