Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW-58096. SDK for transfer refunds. #27

Merged
merged 7 commits into from
Sep 25, 2020

Conversation

KostiantynKobziev
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 19, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 08642ef on feature/HW-58096_sdk_for_transfer_refunds into 56567cc on V3.

@Ssangaran Ssangaran changed the base branch from master to V3 September 24, 2020 14:44
@Ssangaran Ssangaran requested review from Rrathinasabapath and arao6 and removed request for hrandhawa-hw and aseveryn-hw September 24, 2020 14:44
Copy link
Contributor

@Rrathinasabapath Rrathinasabapath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes. Ready to be reviewed by Aparna.

@@ -0,0 +1,8937 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually dont push the lock files. is there a reason we are pushing this in?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed lock file

.gitignore Outdated
@@ -32,3 +32,5 @@ lib/

# Docs folder
docs/

.nyc_output/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this file generated?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed .nyc_output/

@akalichety-hw akalichety-hw merged commit c4a1a95 into V3 Sep 25, 2020
@arao6 arao6 deleted the feature/HW-58096_sdk_for_transfer_refunds branch February 1, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants