Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working Open statement #3
Working Open statement #3
Changes from all commits
5fc2643
b799955
b5396bf
99855e5
dd4b6af
b4f6612
a1b6b17
0b560ed
600e64d
cfd4188
0710905
41242ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I favour commas after e.g./i.e., it isn't a typo but a rather a distinct usage, see discussion: https://www.dailywritingtips.com/comma-after-i-e-and-e-g/ (I'd also say it fits in this text)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not saying this one is a typo, but I think without the comma is more common and so more likely to be consistently used. Same with 1 or 2 spaces after periods, etc. If you prefer having the comma we can aim for that in all our documents, but I definitely feel not having it is likely to stay consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use
vale
and dangerCI gem to encode our rules and do some of these evolving checks. Demo: patcon/dangerfile-test#1 (tho we'd poof a bot instead of using my github token :) )Style rule: https://github.com/patcon/dangerfile-test/blob/master/ci/vale/styles/HyphaCoop/Eg.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty indifferent about which, though I'll need to get used to using commas. But I'm fine with whatever conventions as long as we're on same page :)
(hence my appreciating the bot auto-correcting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commas after "For example" (e.g.) and "Further" (i.e.) tends to be grammatically correct when used without abbreviations. In my experience, but this is based on a lot of academic reading I recognize, commas are the more frequent usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.