-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the proposal for public repos with HTTP(S) URLs #56
Conversation
1. Initialize the repository. | ||
|
||
``` | ||
helm s3 init s3://awesome-bucket/charts --publish https://charts.my-company.tld |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dig it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this.
@hypnoglow LGTM! |
This proposal looks good! |
I had a quick investigation into an implementation. It's made tricky because the I was looking at adding type IndexFile struct {
APIVersion string `json:"apiVersion"`
Generated time.Time `json:"generated"`
Entries map[string]ChartVersions `json:"entries"`
PublicKeys []string `json:"publicKeys,omitempty"`
PublishBaseURI string `json:"publishBaseURI,omitempty"`
} And then changing type Entry struct {
Name string `json:"name"`
Cache string `json:"cache"`
S3URL string `json:"s3URL"`
PublishURL string `json:"url"`
... |
This will be great! |
@hypnoglow any movement on this? I am still using my fork... |
the repo is public. | ||
|
||
1. **helm-s3** also syncs the local cached index `/Users/me/.helm/repository/cache/my-charts-index.yaml` with the remote one. | ||
Note that because of that, charts are fetch-able by public urls locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would authenticated repositories be handled? I'm using a private S3 bucket and exposing it to clients over https with basic authentication. If I use S3 plugin it doesn't store auth info for the publish URL. Perhaps local should keep S3 URLs?
To support publishing existing repositories created with **helm-s3** introduce a new command: | ||
|
||
``` | ||
helm s3 publish my-repo https://charts.my-company.tld |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The publish command is effectively reindexing the repo with different URLs. So why not simply add a --publish url
to the reindexing command?
Was there ever a resolution for this? We're encountering a need to pull charts from a public repo via |
@hypnoglow will either this or #70 be merged in? i've just encountered the need to use this |
Is there any progress on this? |
Superseded by Relative chart URLs. |
Ref: #45