-
Notifications
You must be signed in to change notification settings - Fork 194
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make selection override other filters
When the user clicks highlight(s) in the document and makes a "selection" in the sidebar, we want the selected threads to always be visible. Previously this was handled by clearing other types of filter when the selection was made, in addition to setting the selection. This however meant that after the selection was cleared, the state was different than prior to making the selection, with any non-selection filters being disabled. This commit changes the behavior so that the selection, if present, temporarily overrides other filters rather than being combined with them. This allows the selection to later be removed to revert back to the previous state.
- Loading branch information
1 parent
bbd6408
commit befe424
Showing
2 changed files
with
22 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters