Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty string shown in _No results for “”_ when no search results #9

Closed
seanh opened this issue Jul 1, 2016 · 2 comments
Closed

Empty string shown in _No results for “”_ when no search results #9

seanh opened this issue Jul 1, 2016 · 2 comments

Comments

@seanh
Copy link
Contributor

seanh commented Jul 1, 2016

untitled screencast - edited 24
This was referenced Jul 1, 2016
Closed
Merged
@uzhne
Copy link

uzhne commented Jun 11, 2018

I just signed up for hypothesis and encountered a similar bug but the text is "No results for “function(){return a.getState().filterQuery}”"

robertknight added a commit that referenced this issue Jun 12, 2018
@robertknight
Fix "No results for {query}" message
01915c0 
Usage of `vm.search.query` in the `<sidebar-content>` template was
incorrect. `vm.search` is always set and `query` is a function that
returns a string, not a string.

Fixes #9
@robertknight robertknight mentioned this issue Jun 12, 2018
Merged
@robertknight
Copy link
Member

I can reproduce @uzhne's issue:

screenshot 2018-06-12 11 53 36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robertknight @seanh @uzhne @ajpeddakotla