Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing an annotation such that it no longer matches filters causes it to disappear #10

Closed
seanh opened this issue Jul 1, 2016 · 3 comments
Assignees

Comments

@seanh
Copy link
Contributor

seanh commented Jul 1, 2016

untitled screencast - edited 25

Suggestion: any annotation that matched the search at the time when the search was first made should remain in the search results until the search query is changed, even if edits to the annotation mean that it no longer matches the search.

(Note: you can also see this separate issue in the gif above.)

@lyzadanger lyzadanger self-assigned this Aug 10, 2020
@lyzadanger lyzadanger changed the title Annotations disappear on save if there is a search filter active Editing an annotation such that it no longer matches filters causes it to disappear Aug 14, 2020
@lyzadanger
Copy link
Contributor

I renamed this issue because we've recently solved the issue with new annotations/replies disappearing on save when a search filter is active. This only applies to editing existing annotations.

The desired behavior here of keeping an edited annotation visible even if it no longer matches filters bears a little more though, IMHO. At the very least, it may need to wait until after we've tackled #1242 — it will be more feasible if non-matching annotations are clearly delineated from ones that do match the current filters.

@lyzadanger
Copy link
Contributor

Just a note that I am removing this from the current sprint because it has a dependency on another task in this milestone.

@lyzadanger
Copy link
Contributor

Our search and filtering has changed enough since this was opened that this isn't quite relevant anymore...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants