Hide banner for third party users #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a little bit of cleanup before fixing an issue where the banner shows inappropriate text on publisher sites using third party accounts.
This will make it easier to extend the logic depending on whether the site uses Hypothesis accounts or not.
…rd party accounts This banner is problematic on pages using publisher-managed accounts or a third party annotation service because: - The "Create account" link currently goes to hypothes.is/signup since we do not yet have the ability to customize the output of `/api/links` depending on the authority. - Accounts may not be free to create and the user might not be able to create one themselves. Resolve this by just hiding the banner in this case.
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 90.98% 90.99% +0.01%
==========================================
Files 135 135
Lines 5368 5375 +7
Branches 930 932 +2
==========================================
+ Hits 4884 4891 +7
Misses 484 484
Continue to review full report at Codecov.
|
|
@robertknight Can we just delete this banner from the product? It's stupid. Dan and Dawa previously agreed: https://hypothes-is.slack.com/archives/C07NXBDNW/p1510080494000386 |
|
OK, even better. I'll close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #627
This hides the "To annotate, create a free account or log in" banner on pages that use third-party accounts.