Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for pywb's wombat.js bug #6356

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented May 6, 2024

This PR reverts the changes introduced in #6119 and #6227, which were meant to work around webrecorder/wombat#133

That bug was fixed in webrecorder/wombat#134 and is now part of latest pywb, and already part of viahtml after merging hypothesis/viahtml#657.

Testing steps

  1. Check out this branch
  2. Open viahtml locally, and run python ./bin/build_static.py. This will copy and expose pywb static assets, including wombat.js
  3. Go to http://localhost:9083/https://www.example.com/ and open the "Version" tab of the help panel.
    image
  4. Click "Copy version details". You should see a success toast message.

Note

We are not using GitHub revert functionality, because changes were applied in two different PRs, and that would require doing the revert in two steps.

@acelaya acelaya requested a review from robertknight May 6, 2024 10:31
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (65cc9b6) to head (360c8dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6356      +/-   ##
==========================================
- Coverage   99.43%   99.43%   -0.01%     
==========================================
  Files         271      271              
  Lines       10239    10238       -1     
  Branches     2425     2425              
==========================================
- Hits        10181    10180       -1     
  Misses         58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a manual test of this myself, but the change looks fine.

@acelaya acelaya merged commit f4e5e98 into main May 7, 2024
4 checks passed
@acelaya acelaya deleted the rollback-wombat-workaround branch May 7, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants