Bump preact from 10.21.0 to 10.22.0 #1560
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
|
I added a couple of changes to fix issues that came up with this update. You might want to be aware of them @acelaya . |
src/components/input/SelectNext.tsx
Outdated
| @@ -287,7 +287,7 @@ function SelectMain<T>({ | |||
| const buttonRef = useSyncedRef(elementRef); | |||
| const defaultButtonId = useId(); | |||
| const extraProps = useMemo( | |||
| () => (listboxAsPopover ? { popover: '' } : {}), | |||
| () => (listboxAsPopover ? { popover: 'auto' } : {}), | |||
There was a problem hiding this comment.
The typecheck still fails, as it infers 'auto' as string. One option is setting 'auto' as const, but since now popover is part of the type, you can also move this logic to a regular prop where the value is dynamically set to auto or false, and I would expect that, in the second case, the attribute is not set at all in the DOM node.
There was a problem hiding this comment.
🤦 - Indeed. I ran the tests locally but forgot to run typechecking. I moved popover to be an unconditionally set prop, but had to use the value undefined rather than false for the case where listboxAsPopover is disabled, since Preact is not handling boolean values correctly for this prop.
There was a problem hiding this comment.
I filed an upstream issue about handling boolean values for this prop: preactjs/preact#4391.
Bumps [preact](https://github.com/preactjs/preact) from 10.21.0 to 10.22.0. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](preactjs/preact@10.21.0...10.22.0) --- updated-dependencies: - dependency-name: preact dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
robertknight
force-pushed
the
dependabot/npm_and_yarn/preact-10.22.0
branch
from
d29a10c
to
1ae0459
Compare
Preact's latest typings allow setting popover to a boolean value, but this still renders `popover="true"` and "true" is an invalid value. Instead set the value to "auto" which is the default value [1]. [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover
The latest Preact release warns about `<tr>` elements that have a `<table>` as their direct parent. See preactjs/preact#4375.
robertknight
force-pushed
the
dependabot/npm_and_yarn/preact-10.22.0
branch
from
1ae0459
to
c81e90e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1560 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 1037 1036 -1
Branches 394 394
=========================================
- Hits 1037 1036 -1 ☔ View full report in Codecov by Sentry. |
Bumps preact from 10.21.0 to 10.22.0.
Release notes
Sourced from preact's releases.
Commits
494f08410.22.0 (#4385)cece8c3fix isolated rerenders (#4382)6449692Merge pull request #4378 from preactjs/types/popover598765efeat: Add popover types1b4e683Merge pull request #4377 from preactjs/ci/compressed-sized12d306Merge branch 'main' into ci/compressed-sizebfdd189Merge pull request #4376 from preactjs/debug/button-anchor-nesting06a2df1Merge branch 'main' into debug/button-anchor-nestingc29caa3Merge pull request #4375 from preactjs/debug/tr-warning4523933ci: Skip running compressed-size builds twiceDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)