Replace %20 with space when displaying filenames

hypothesis · Oct 8, 2015 · 2b0b320 · 2b0b320
1 parent 7ec1574
commit 2b0b320
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/h/static/scripts/filter/document-domain.js b/h/static/scripts/filter/document-domain.js
@@ -21,12 +21,12 @@ module.exports = function() {
       var parts = uri.split('/');
       var filename = parts[parts.length - 1];
       if (filename) {
-        return '(' + filename + ')';
+        return '(' + decodeURIComponent(filename) + ')';
       }
     }
 
     if (domain && domain !== title) {
-      return '(' + domain + ')';
+      return '(' + decodeURIComponent(domain) + ')';
     } else {
       return '';
     }

diff --git a/h/static/scripts/filter/test/document-domain-test.js b/h/static/scripts/filter/test/document-domain-test.js
@@ -38,6 +38,15 @@ describe('documentDomain', function() {
     assert(domain === '(MyFile.pdf)');
   });
 
+  it('replaces %20 with " "', function() {
+    var domain = documentDomainFilterProvider()({
+      title: 'example.com',
+      uri: 'file:///home/seanh/My%20File.pdf'
+    });
+
+    assert(domain === '(My File.pdf)');
+  });
+
   it('escapes HTML in the document domain', function() {
     var spamLink = '<a href="http://example.com/rubies">Buy rubies!!!</a>';