Remove client-side profile forms

Remove the client-side profile forms which are now implemented on the server. This actually removes a couple of dependencies which we can also remove. In particular the "tabbable" directive from angular-bootstrap is no longer needed.
hypothesis · Oct 21, 2015 · 3939b43 · 3939b43
1 parent e2cdf3b
commit 3939b43
Show file tree

Hide file tree

Showing 15 changed files with 33 additions and 1,031 deletions.
diff --git a/h/assets.yaml b/h/assets.yaml
@@ -7,10 +7,6 @@ angular_animate:
   filters: uglifyjs
   output: scripts/vendor/angular-animate.min.js
   contents: ../../node_modules/angular-animate/angular-animate.js
-angular_bootstrap:
-  filters: uglifyjs
-  output: scripts/vendor/angular-bootstrap-tabbable.min.js
-  contents: h:static/scripts/vendor/angular-bootstrap-tabbable.js
 angular_resource:
   filters: uglifyjs
   output: scripts/vendor/angular-resource.min.js
@@ -115,7 +111,6 @@ app_js:
     - jquery
     - angular
     - angular_animate
-    - angular_bootstrap
     - angular_resource
     - angular_route
     - angular_sanitize

diff --git a/h/static/scripts/account-controller.js b/h/static/scripts/account-controller.js
diff --git a/h/static/scripts/app.coffee b/h/static/scripts/app.coffee
@@ -86,7 +86,6 @@ module.exports = angular.module('h', [
   'angulartics'
   'angulartics.google.analytics'
   'angular-jwt'
-  'bootstrap'
   'ngAnimate'
   'ngResource'
   'ngRoute'
@@ -98,7 +97,6 @@ module.exports = angular.module('h', [
 ])
 
 .controller('AppController', require('./app-controller'))
-.controller('AccountController', require('./account-controller'))
 .controller('AnnotationUIController', require('./annotation-ui-controller'))
 .controller('AnnotationViewerController', require('./annotation-viewer-controller'))
 .controller('AuthController', require('./auth-controller'))
@@ -116,10 +114,7 @@ module.exports = angular.module('h', [
 .directive('statusButton', require('./directive/status-button'))
 .directive('thread', require('./directive/thread'))
 .directive('threadFilter', require('./directive/thread-filter'))
-.directive('match', require('./directive/match'))
 .directive('spinner', require('./directive/spinner'))
-.directive('tabbable', require('./directive/tabbable'))
-.directive('tabReveal', require('./directive/tab-reveal'))
 .directive('shareDialog', require('./directive/share-dialog'))
 .directive('windowScroll', require('./directive/window-scroll'))
 .directive('dropdownMenuBtn', require('./directive/dropdown-menu-btn'))

diff --git a/h/static/scripts/directive/match.coffee b/h/static/scripts/directive/match.coffee
diff --git a/h/static/scripts/directive/tab-reveal.coffee b/h/static/scripts/directive/tab-reveal.coffee
diff --git a/h/static/scripts/directive/tabbable.coffee b/h/static/scripts/directive/tabbable.coffee
diff --git a/h/static/scripts/directive/test/match-test.coffee b/h/static/scripts/directive/test/match-test.coffee
diff --git a/h/static/scripts/karma.config.js b/h/static/scripts/karma.config.js
@@ -29,7 +29,6 @@ module.exports = function(config) {
       '../../../node_modules/angular-route/angular-route.js',
       '../../../node_modules/angular-sanitize/angular-sanitize.js',
       '../../../node_modules/ng-tags-input/build/ng-tags-input.min.js',
-      'vendor/angular-bootstrap-tabbable.js',
       'vendor/katex.js',
 
       // Test deps