Change perms when moving annotations btwn groups

Fixes #2713.

h/static/scripts/directive/annotation.coffee

@@ -432,6 +432,8 @@ AnnotationController = [
       # switching groups. See GH #2689 for context
       if !model.id
         model.group = groups.focused().id
+        if permissions.isShared(vm.annotation.permissions, vm.annotation.group)
+          model.permissions = permissions.shared(model.group)
 
     this
 ]

h/static/scripts/directive/test/annotation-test.coffee

@@ -608,6 +608,43 @@ describe 'annotation', ->
       $rootScope.$broadcast(events.GROUP_FOCUSED)
       assert.equal(annotation.group, 'new-group')
 
+    it "updates perms when moving new annotations to the focused group", ->
+      # id must be null so that AnnotationController considers this a new
+      # annotation.
+      annotation.id = null
+      annotation.group = 'old-group'
+      annotation.permissions = {read: [annotation.group]}
+
+      # This is a shared annotation.
+      fakePermissions.isShared.returns(true)
+      createDirective()
+
+      # Make permissions.shared() behave like we expect it to.
+      fakePermissions.shared = (groupId) ->
+        return {read: [groupId]}
+
+      fakeGroups.focused = sinon.stub().returns({id: 'new-group'})
+      $rootScope.$broadcast(events.GROUP_FOCUSED)
+
+      assert.deepEqual(annotation.permissions.read, ['new-group'])
+
+    it "does not change perms when moving new private annotations", ->
+      # id must be null so that AnnotationController considers this a new
+      # annotation.
+      annotation.id = null
+      annotation.group = 'old-group'
+      annotation.permissions = {read: ['acct:bill@localhost']}
+      createDirective()
+
+      # This is a private annotation.
+      fakePermissions.isShared.returns(false)
+
+      fakeGroups.focused = sinon.stub().returns({id: 'new-group'})
+      $rootScope.$broadcast(events.GROUP_FOCUSED)
+
+      assert.deepEqual(annotation.permissions.read, ['acct:bill@localhost'],
+        'The annotation should still be private')
+
 
 describe("AnnotationController", ->