New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal via url appears in stream #2390

Closed

judell opened this issue Jul 22, 2015 · 2 comments

Contributor

judell commented Jul 22, 2015

Example annotation: https://hypothes.is/a/4je60nhbTBeyLUArBNkiqw

Link in the stream: https://via.hypothes.is/static/__shared/viewer/web/viewer.html?file=/id_/http://langsci-press.org/catalog/view/75/22/295-1

From Eitan's point of view, it's working. This is the API call the browser makes, and it does return results:

https://hypothes.is/api/search?uri=https%3A%2F%2Fwww.google.com%2Fsearch%3Fq%3Dhttp%253A%252F%252Flangsci-press.org%252Fcatalog%252Fview%252F75%252F22%252F295-1%26oq%3Dhttp%253A%252F%252Flangsci-press.org%252Fcatalog%252Fview%252F75%252F22%252F295-1%26aqs%3Dchrome..69i58j69i57j69i60.4648j0j4%26sourceid%3Dchrome%26es_sm%3D93%26ie%3DUTF-8

But the expected target is really http://langsci-press.org/catalog/view/75/22/295-1, not the behind-the-scenes via URL.

Contributor

tilgovi commented Jul 22, 2015

So, via is adding a rel=canonical. @nickstenning add this to your mental map of things to consider in the normalization / search designing.

nickstenning added Bug labels

Contributor

nickstenning commented Feb 9, 2016

Fixed today by running a migration in production to remove legacy via URLs from the database.

nickstenning closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment